Add new -var args for tf plan. #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we added -var atlantis_repo=runatlantis/atlantis but the '/' character is not a valid character for the AWS assume role session name. To fix this, this commit adds -var atlantis_repo_owner=runatlantis and -var atlantis_repo_name=atlantis (where runatlantis and atlantis would be the values for the repo the pull request is from ).
Codecov Report
@@ Coverage Diff @@
## master #300 +/- ##
==========================================
+ Coverage 70.5% 70.54% +0.03%
==========================================
Files 61 61
Lines 3635 3639 +4
==========================================
+ Hits 2563 2567 +4
Misses 893 893
Partials 179 179
Continue to review full report at Codecov.
|
jolexa
approved these changes
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we added -var atlantis_repo=runatlantis/atlantis but the '/'
character is not a valid character for the AWS assume role session name.
To fix this, this commit adds -var atlantis_repo_owner=runatlantis and
-var atlantis_repo_name=atlantis (where runatlantis and atlantis would
be the values for the repo the pull request is from ).